Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the HAI cli to cli-dev.go in accordance with issue #374 #387

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

georgievaVMW
Copy link
Contributor

Renamed the HAI cli to cli-dev.go in accordance with issue #374 and corrected codecov with the new file name.

I explored the option to move cli.go to other folder to be more explicit that it is an optional workflow but it uses private methods and classes from the installer package. If it is moved we need to cut functionalities from the cli or refactor all other files which in turn leads to other problems or conflicts. With this in mind I decided that it is more viable option to just rename it at this time.

…zu#374 and corrected codecov with the new file name.

I explored the option to move cli.go to other folder to be more explicit that it is an optional workflow but it uses private methods and classes from the installer package. If it is moved we need to cut functionalities from the cli or refactor all other files which in turn leads to other problems or conflicts. With this in mind I decided that it is more viable option to just rename it at this time.
Copy link
Contributor

@pshail pshail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusha94 anusha94 merged commit 1e7592e into vmware-tanzu:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants