Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include more details #382

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

anusha94
Copy link
Contributor

What this PR does / why we need it:
Adding more details on the BYOH Glossary, what the provider is, and reorganized few sections.
Removed the compatibility matrix, because I think the k8s compatibility is going to get more tedious to update when we move to major.minor.* versions. Once we tackle that, maybe then we could have a compatibility matrix listed. As of now, its just one version, so added that in text instead.

Fixes #179

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pshail
Copy link
Contributor

pshail commented Feb 15, 2022

some nits, overall LGTM

@anusha94 anusha94 requested a review from pshail February 15, 2022 14:40
Copy link
Contributor

@pshail pshail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dharmjit dharmjit merged commit c5bb8f9 into vmware-tanzu:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README to include more details
4 participants