-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch control plane IP at runtime #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits. Otherwise lgtm
small nit, rest is LGTM |
Hey, @pshail please Iet me know the edits required. |
@anusha94 just suggested the other way round 🙃 ... sorry for this @NilanjanDaw i just saw the resolved comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't have strong opinion about this. But I feel a little concern about this hard code way, it looks like a potential bug may occurs one day in the future. It will be better if we can do this more smart. What I can think of is as followed, just for refer:
Anyway, if you are all fine by current fix, I am also ok with it. |
I think that’s a very valid concern. We did think about it - but we know we won’t have that many containers now, so this felt a little complex to achieve something so small. Before this PR - we were hardcoding the full IP, see this removed line from Makefile, so compared to that, this PR added some smartness in fetching the subnet and hardcoding only the last octet. |
What this PR does / why we need it:
Set the
CONTROL_PLANE_ENDPOINT_IP
programmatically at runtime during E2E tests based on docker network settings.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #206