Add BYOH cluster create sequence diagram

[dharmjit]

Co-authored-by: Anusha Hegde [email protected]

What this PR does / why we need it:

This PR adds a sequence diagram for BYOH cluster creation workflow.

Which issue(s) this PR fixes :
Fixes #

[codecov-commenter]

Codecov Report

Merging #355 (e5d4629) into main (df97a2a) will not change coverage.
The diff coverage is n/a.

❗ Current head e5d4629 differs from pull request most recent head 35429ae. Consider uploading reports for the commit 35429ae to get more accurate results

@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   61.92%   61.92%           
=======================================
  Files          23       23           
  Lines        1731     1731           
=======================================
  Hits         1072     1072           
  Misses        587      587           
  Partials       72       72           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df97a2a...35429ae. Read the comment docs.

[huchen2021]

How about adding "Patch BYOH Provider on Management Cluster"?

[dharmjit]

How about adding "Patch BYOH Provider on Management Cluster"?

@huchen2021 , I do not have strong views on this, but my thoughts were that it's implied that the provider is installed when we say management cluster. I know, currently we have to patch BYOH provider separately but that might not be the case going forward.

[anusha94]

How about adding "Patch BYOH Provider on Management Cluster"?

Yes, that's a valid point @huchen2021
We did discuss about this, but for cluster create, we are assuming the provider is already present on the management cluster - this is something as a preparation step and not really part of "Cluster Create" operation. Makes sense?

[pshail]

@dharmjit shall we create an arch.md file where we describe these diagrams and embed the png as well, wdyt?

[jamiemonserrate]

LGTM!

[dharmjit]

@dharmjit shall we create an arch.md file where we describe these diagrams and embed the png as well, wdyt?

Yes, referring to these diagrams in other docs is a good idea for discovery.

[anusha94]

Yes, referring to these diagrams in other docs is a good idea for discovery.

Let's use #238 for this.

@pshail wdyt of the sequence diagram in this PR? Need changes? Good to merge?

[pshail]

overall /LGTM
@dharmjit minor nits of arrow types for return messages and wherever possible callout sync/async calls

[pshail]

@dharmjit let me take care of these nits in #238 , we can merge this
LGTM!