Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue-290 #343

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Add tests for issue-290 #343

merged 4 commits into from
Jan 25, 2022

Conversation

huchen2021
Copy link
Contributor

Fixes #335

Signed-off-by: chen hui huchen@vmware.com

Signed-off-by: chen hui <huchen@vmware.com>
@huchen2021 huchen2021 requested review from anusha94 and dharmjit and removed request for anusha94 January 20, 2022 08:41
@huchen2021 huchen2021 requested a review from anusha94 January 24, 2022 02:37
@huchen2021 huchen2021 requested a review from anusha94 January 24, 2022 07:38
huchen2021 and others added 2 commits January 24, 2022 15:45
Co-authored-by: Anusha Hegde <anushah@vmware.com>
Signed-off-by: chen hui <huchen@vmware.com>
dharmjit
dharmjit previously approved these changes Jan 24, 2022
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/builder/builders.go Show resolved Hide resolved
test/builder/builders.go Outdated Show resolved Hide resolved
Co-authored-by: Anusha Hegde <anushah@vmware.com>
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@huchen2021 huchen2021 requested a review from dharmjit January 25, 2022 07:42
@huchen2021 huchen2021 merged commit 5b1a2b9 into vmware-tanzu:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for issue-290
4 participants