Added code coverage report generation and upload to codecov #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This will provide continuous test code coverage for
BYOH. The stepapt-get install golang-ginkgo-devinstalls version1.2.0which does not handle the creation of code coverage report, hence the command is updated togo getcodecove2eandwebhooktests are skippedWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #309
Additional information
A successful run on my fork is https://github.com/dharmjit/cluster-api-provider-bringyourownhost/runs/4813076281?check_suite_focus=true and code coverage can be seen here https://app.codecov.io/gh/dharmjit/cluster-api-provider-bringyourownhost/
Special notes for your reviewer
Webhook tests are excluded from test coverage currently and will be included in subsequent PR as we need to figure out how to remove some specific files only.