Handle bundleLookupTag in e2e tests #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hui Chen <[email protected]>
|
@huchen2021 Better to link in PR description with the |
OK |
anusha94
reviewed
Jan 12, 2022
test/e2e/data/infrastructure-provider-byoh/v1beta1/cluster-with-kcp.yaml
Show resolved
Hide resolved
Signed-off-by: chen hui <[email protected]>
anusha94
approved these changes
Jan 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is the second half of the problem mentioned in #259. The bundleLookupTag is currently hardcoded in the e2e test. While this works for now, this value should be configurable.
Signed-off-by: Hui Chen [email protected]
Fixes #303