Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define strategy to provide value for bundleLookupTag in Cluster Template #287

Merged
merged 20 commits into from
Jan 13, 2022

Conversation

huchen2021
Copy link
Contributor

@huchen2021 huchen2021 commented Dec 14, 2021

Fixes #259

Signed-off-by: Hui Chen [email protected]

…or: ST1016: methods on the same type should have the same receiver name (seen 2x "c", 5x "r") (stylecheck)

Signed-off-by: Hui Chen <[email protected]>
Hui Chen added 2 commits January 4, 2022 14:08
Signed-off-by: Hui Chen <[email protected]>
Signed-off-by: Hui Chen <[email protected]>
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
PROJECT Show resolved Hide resolved
PROJECT Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook_test.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook_test.go Outdated Show resolved Hide resolved
Signed-off-by: Hui Chen <[email protected]>
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits.

PROJECT Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook_test.go Outdated Show resolved Hide resolved
apis/infrastructure/v1beta1/byocluster_webhook_test.go Outdated Show resolved Hide resolved
Hui Chen and others added 4 commits January 11, 2022 15:42
Hui Chen added 3 commits January 12, 2022 10:44
@huchen2021 huchen2021 requested a review from anusha94 January 12, 2022 03:38
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
lgtm

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you

@huchen2021 huchen2021 merged commit 26b4bc2 into vmware-tanzu:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define strategy to provide value for bundleLookupTag in Cluster Template
5 participants