🐛 Fix Draft Release Github action to fetch the tag name #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env.GITHUB_REF is replaced with github.ref_name as this variable contains the branch or tag name that triggered the workflow run. Signed-off-by: Dharmjit Singh <[email protected]>
pshail
approved these changes
Dec 13, 2021
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/approve |
|
Thanks @dharmjit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.GITHUB_REFis replaced withgithub.ref_nameas this variable contains the branch or tag name that triggered the workflow run. Refer this - https://docs.github.com/en/actions/learn-github-actions/contexts#github-contextSigned-off-by: Dharmjit Singh [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #281
Additional information
Special notes for your reviewer
Performed validation in this repo https://github.com/dharmjit/cluster-api-provider-bringyourownhost. Refer -
Job Test Outputfor https://github.com/dharmjit/cluster-api-provider-bringyourownhost/runs/4505890775?check_suite_focus=true or the draft release assets.