Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Go Report Card badge in Readme #249

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Added Go Report Card badge in Readme #249

merged 1 commit into from
Nov 17, 2021

Conversation

dharmjit
Copy link
Contributor

Signed-off-by: Dharmjit Singh [email protected]

What this PR does / why we need it:
This PR will add the Go Report card badge in the readme which will also highlight the code quality health of the project.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #177

Additional information

Special notes for your reviewer

Signed-off-by: Dharmjit Singh <[email protected]>
@anusha94
Copy link
Contributor

Do you think it makes sense to keep doc reference and go report badge in a separate line? This could be in the first line and linter + post merge on main could be in the second line. WDYT
Screenshot 2021-11-17 at 12 50 44 PM

@dharmjit
Copy link
Contributor Author

Do you think it makes sense to keep doc reference and go report badge in a separate line? This could be in the first line and linter + post merge on main could be in the second line. WDYT

We don't have too many badges, It looks okay in my opinion. Maybe we can improve the name of post merge on main badge.

@dharmjit dharmjit merged commit 97eb96d into main Nov 17, 2021
@dharmjit dharmjit deleted the doc-add-goreportcard branch November 19, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go Report Card Badge
4 participants