Add Prow like actions for BYOH #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsher31
force-pushed
the
prow-actions
branch
from
a8ffc40 to
776b85c
Compare
|
/cc @pshail for you #220 (comment) (Almost all the automation is in place, still need to figure out |
dharmjit
reviewed
Nov 16, 2021
dharmjit
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Awesome Work @shamsher31. LGTM, only some suggestions/questions.
dharmjit
approved these changes
Nov 17, 2021
|
Glad to see this being used out in the wild! Feel free to ping me with any questions using the prow bot! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This will enable Prow like actions to interact with PR and issues.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #246
Additional information
Prow Github Action: https://github.com/jpmcb/prow-github-actions
Labeler: https://github.com/actions/labeler
Special notes for your reviewer
You can use commands like:
/assign @anusha94
/cc @jamiemonserrate
/kind enhancement
/area installer
/approve
/lgtm
/hold
/close
/reopen
See https://github.com/kubernetes/kubernetes/pulls for more info.