Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installer documentation #230

Merged
merged 8 commits into from
Nov 16, 2021

Conversation

ratanasovvmw
Copy link
Contributor

@ratanasovvmw ratanasovvmw commented Nov 10, 2021

This PR fixes issue #226

Fixes #226

@anusha94 anusha94 requested review from anusha94, dharmjit and a team and removed request for dharmjit and anusha94 November 10, 2021 15:37
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Outdated Show resolved Hide resolved
docs/local_dev.md Show resolved Hide resolved
docs/local_dev.md Show resolved Hide resolved
@anusha94 anusha94 requested a review from a team November 12, 2021 12:38
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwmqwer
Copy link
Contributor

lwmqwer commented Nov 16, 2021

lgtm too

@lwmqwer lwmqwer self-requested a review November 16, 2021 08:39
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Nits only

docs/local_dev.md Show resolved Hide resolved
docs/local_dev.md Show resolved Hide resolved
docs/local_dev.md Show resolved Hide resolved
@anusha94 anusha94 merged commit 689d90e into vmware-tanzu:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Installer instructions in local-dev guide
5 participants