Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value for downloadpath #227

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

anusha94
Copy link
Contributor

What this PR does / why we need it:
Updating the default to /var/lib/kubernetes-artifacts to be more clear
on the intent of the downloaded components

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #218

Updating the default to /var/lib/kubernetes-artifacts to be more clear
on the intent of the downloaded components
agent/main.go Outdated Show resolved Hide resolved
dharmjit
dharmjit previously approved these changes Nov 16, 2021
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lwmqwer
lwmqwer previously approved these changes Nov 16, 2021
Copy link
Contributor

@lwmqwer lwmqwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anusha94 anusha94 dismissed stale reviews from lwmqwer and dharmjit via ae173f1 November 16, 2021 09:42
@anusha94 anusha94 requested review from dharmjit and lwmqwer and removed request for ratanasovvmw November 16, 2021 13:27
@jamiemonserrate jamiemonserrate merged commit c7321ed into vmware-tanzu:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default value for downloadPath argument in host-agent
6 participants