Refactored Host Agent, Installer Integration #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
previously approved these changes
Nov 9, 2021
Reverted the changes for agent installer integration Added SkipInstallation, DownloadPath fields in the agent reconciler struct. Initialization of Installer Type is handled in the agent reconciler Agent Reconciler tests are only covering the code path for SkipInstallation is true Installer k8s support bumped to v1.22.3 Signed-off-by: Dharmjit Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkipInstallation,DownloadPathfields in the agent reconciler struct.Byohinstaller to bundle k8s version tov1.22.3Signed-off-by: Dharmjit Singh [email protected]
What this PR does / why we need it:
The Installer logic is failing due to recent changes for host agent/reconciler integration. The PR removes some of the reconciler test cases and only tests the code path where
SkipInstallationis true.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Additional information
Special notes for your reviewer
We need to rethink about the installer integration going forward so that we can have minimal coupling and more test coverage.