Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --short to report kubectl version #215

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

shamsher31
Copy link
Contributor

@shamsher31 shamsher31 commented Nov 8, 2021

What this PR does / why we need it:
Before:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.2", GitCommit:"8b5a19147530eaac9476b0ab82980b4088bbc1b2",
GitTreeState:"clean", BuildDate:"2021-09-15T21:31:32Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192",
GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

After:

$ kubectl version --short
Client Version: v1.22.2
Server Version: v1.21.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Additional information

Special notes for your reviewer

@dharmjit
Copy link
Contributor

dharmjit commented Nov 8, 2021

Thanks @shamsher31 for raising this PR. I am not sure, but is it advised to use kubectl version --short or what the practice is in general.

@shamsher31
Copy link
Contributor Author

Thanks @shamsher31 for raising this PR. I am not sure, but is it advised to use kubectl version --short or whats the practice is in general.

It helps users get the exact kubectl version which they can quickly copy and past in a bug report. We have used it in a couple of projects. eg: istio/istio#27108 and istio/istio#29213

@dharmjit dharmjit requested a review from anusha94 November 8, 2021 08:09
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusha94 anusha94 merged commit b733142 into vmware-tanzu:main Nov 9, 2021
@shamsher31 shamsher31 deleted the issue-temp-update branch November 9, 2021 04:41
@shamsher31 shamsher31 self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants