Changes to OS and package updates as a follow-up on the discussion in PR #169 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the step that changes the OS auto-upgrading settings. Changed the step that installs outside packages such as kubeadm, kubelet and so on to disable auto-upgrading after installing the package. Updated the tests which are checking for number of completed steps with the new values.
ratanasovvmw
reviewed
Nov 5, 2021
ratanasovvmw
approved these changes
Nov 17, 2021
anusha94
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the step that changes the OS auto-upgrading settings as this is work of the site operator and that step is not needed.
Changed the step that installs external packages such as kubeadm, kubelet and so on to disable auto-upgrading after installing the package.
Updated the tests which are checking for number of completed steps with the new values.
Link to PR #169