Added additional tests for installer and algo installer #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to algo installer to check for rollback when an error occurs mid installation.
ratanasovvmw
reviewed
Nov 2, 2021
Made PreviewChanges and its test to check for error. Implemented mockStep for testing the mockUbuntu and made mockUbuntu to count number of calls for do and undo steps as well as the ability to define which step is with error.
ratanasovvmw
reviewed
Nov 3, 2021
…instead of only their count.
…VMW/cluster-api-provider-bringyourownhost into hainstaller-algo-test-rollback
ratanasovvmw
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fix and a test for PreviewChanges when os/k8s is not supported.
Added test to algo installer to check for rollback when an error occurs mid installation.