Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1.4.0 #55

Merged
merged 40 commits into from
Feb 24, 2021
Merged

Release/v1.4.0 #55

merged 40 commits into from
Feb 24, 2021

Conversation

kshrutik
Copy link
Contributor

@kshrutik kshrutik commented Feb 23, 2021

Release notes:

  • New remediation jobs added for Azure:
  • Enable Soft Delete for Storage Account BlobService (azure_storage_soft_delete_not_enabled)
  • Enable Logging for Key Vault (azure_key_vault_logging_for_keyvault_enabled)
  • Enable SQL Server Auditing (azure_sql_auditing_on_server)
  • Enable Transparent Data Encryption for SQL Database (azure_sql_data_encryption_on)
  • Configure Storage Account Encryption at rest with Customer Managed Keys (azure_storage_encryption_at_rest_not_configured_with_customer_managed_key)

pauldallen and others added 30 commits August 20, 2020 13:00
#3)

* PLA-17940 updating constraints and fixing s3_enable_access_logging to not remediate the logging target bucket

* PLA-17940 fixing copyright info
* Update minimum permissions for the job
* Add more logs when permission is missing

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* PLA-16779: Add remediation job for azure security group port 22

* add test dependencies

* update README.md

* add deployment info to the README

* add rule information

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* PLA-18743: Add remediation job for closing port 22 for VM
* add tests for azure_vm_close_port_22 to tox
* add deployment details

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* add remediation job for closing RDP access

* Add remediation job for remove public access for blob

* Add remediation job to allow only https traffic to storage account

* update READMEs to fix broken links

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* handle the case when the security rule port is a range

* Add minimum permissions for each remediation jobs

* add link to built in roles

Co-authored-by: Mohammad Zuber Khan <[email protected]>
Co-authored-by: Mohammad Zuber Khan <[email protected]>
* update the remediation job payload (#21)

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* PLA-20459: Add rule information for the remediation job

* add another rule remediated by the job

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* Release/v1.0.0 (#7)

* PLA-17940 updating constraints and fixing s3_enable_access_logging to… (#3)

* PLA-17940 updating constraints and fixing s3_enable_access_logging to not remediate the logging target bucket

* PLA-17940 fixing copyright info

* Updated readme to have link for reporting issues (#4)

Co-authored-by: svikramjeet <[email protected]>

* S3 access logs permissions (#6)

* Update minimum permissions for the job
* Add more logs when permission is missing

Co-authored-by: Mohammad Zuber Khan <[email protected]>

Co-authored-by: Paul Allen <[email protected]>
Co-authored-by: svikramjeet <[email protected]>
Co-authored-by: Zuber <[email protected]>
Co-authored-by: Mohammad Zuber Khan <[email protected]>

* Release/v1.1.0 (#17)

* PLA-17940 updating constraints and fixing s3_enable_access_logging to… (#3)

* PLA-17940 updating constraints and fixing s3_enable_access_logging to not remediate the logging target bucket

* PLA-17940 fixing copyright info

* Updated readme to have link for reporting issues (#4)

Co-authored-by: svikramjeet <[email protected]>

* S3 access logs permissions (#6)

* Update minimum permissions for the job
* Add more logs when permission is missing

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* change the way cloudAccountId is parsed from Job Paramaters (#9)

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* PLA-16779: Add remediation job for azure security group port 22 (#10)

* PLA-16779: Add remediation job for azure security group port 22

* add test dependencies

* update README.md

* add deployment info to the README

* add rule information

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* Add remediation job for closing port 22 for VM (#11)

* PLA-18743: Add remediation job for closing port 22 for VM
* add tests for azure_vm_close_port_22 to tox
* add deployment details

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* Add remediation jobs for storage and RDP violations (#12)

* add remediation job for closing RDP access

* Add remediation job for remove public access for blob

* Add remediation job to allow only https traffic to storage account

* update READMEs to fix broken links

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* fix the parameters passed for remediation (#13)

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* add check for existing permissions before adding new (#15)

Co-authored-by: Mohammad Zuber Khan <[email protected]>

* Fix ports range for network security groups (#19) (#20)

* handle the case when the security rule port is a range

* Add minimum permissions for each remediation jobs

* add link to built in roles

Co-authored-by: Mohammad Zuber Khan <[email protected]>

Co-authored-by: Zuber <[email protected]>
Co-authored-by: Mohammad Zuber Khan <[email protected]>

Co-authored-by: Paul Allen <[email protected]>
Co-authored-by: svikramjeet <[email protected]>
Co-authored-by: Zuber <[email protected]>
Co-authored-by: Mohammad Zuber Khan <[email protected]>

Co-authored-by: Paul Allen <[email protected]>
Co-authored-by: svikramjeet <[email protected]>
Co-authored-by: Zuber <[email protected]>
Co-authored-by: Mohammad Zuber Khan <[email protected]>
Merging Release/v1.2.0 (#26) to Dev
* Azure security center enable ddos protection remediation script

* Removed .DS_Store file

* Made changes in README.md

* Addressed the review comments

* Pre-commit changes added

* Made changes in README.md

* Added the unit test in tox.ini

* fix requirements-dev.txt for tox run

Co-authored-by: Mohammad Zuber Khan <[email protected]>
Co-authored-by: Shrutika Kulkarni <[email protected]>
* Azure Storage default network access deny remediation script

* .DS_Store file removed

* Fixed some logging messages

* Added unit test in tox.ini

* Changed requirements.txt

* Fixed requirements-dev.txt
* remove unused logcall function

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* Add remediation job to enable ELB access logs

Co-authored-by: Mohammad Zuber Khan <[email protected]>
* PLA-21822 fixing whitespace
PLA-20589: Enable Azure SQL Server Auditing remediation job
kshrutik and others added 10 commits January 11, 2021 11:59
* Changed Storage account name

* PLA-22317 - Changed the function name
* PLA-22301 - Remediation job to encrypt storage account with CMK

* PLA-22301 - Addressed review comments and added Diagnostic Settings for KeyVault
* PLA-23159 - Updated Remediation Job for Storage Account encryption

* PLA-23159 - Added Comments

* PLA-23159 - Updated the Storage Account job

* PLA-23159 - Updated Storage encryption job
…47)

* PLA-23081 - Updated Remediation Job to enable SQL Auditing on Server

* PLA-23081 - Added Comments

* PLA-23081 - Updated the SQL Auditing job
* PLA-22903 - Updated Remediation Job for Key Vault Logging

* PLA-22903 - Updated Key Vault Logging job

* PLA-22903 - Added Comments

* PLA-22903 - Fixed review comments

* PLA-22903 - Fixed Review Comments

* PLA-22903 - Updated the key vault logging job
Copy link
Contributor

@vikramsinghvirdi vikramsinghvirdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Enable SQL Server Auditing

This job enables server blob auditing policy for the SQL Database Server. It checks for the existence of the Storage Account created by CHSS, if the Storage Account exists then it assigns a Storage Blob Contributer Role to the SQL Server. If the Storage Account Created by CHSS does not exists then it creates one.
The Storage Account created by CHSS is prefixed with "chss" and contains tag `{"Created By" : "CHSS"}`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this information!

@vikramsinghvirdi vikramsinghvirdi merged commit d51e09f into master Feb 24, 2021
@vikramsinghvirdi vikramsinghvirdi deleted the release/v1.4.0 branch February 24, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants