Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ISOs and adjacent bug-fixes #93

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Refactor ISOs and adjacent bug-fixes #93

merged 1 commit into from
Oct 3, 2021

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Oct 3, 2021

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Refactors ISO configurations

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request

Also in the payload:

Related to Existing Issues

Issue Number: See Context of the Pull Request

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Uses vendor / distributor `.iso` file name and checksum.
- Adds/updates build variables to include `iso_path`, `iso_file`, `iso_checksum_type`, and `iso_checksum_value`.
- Updates code style for the variables passed to a templatefile.
- Replaces the term "redhat-variant" with "redhat-derivative".
- Adds ansible to Ubuntu 20.04 and 18.06 #54
Copy link
Collaborator Author

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Self Reviewed
✅ Self Approved

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/medium Priority Medium sev/minor Minor size/l Large type/bug Bug type/docs Documentation type/enhancement Enhancement type/refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant