Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu 20.04 user-data #53

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Fix Ubuntu 20.04 user-data #53

merged 1 commit into from
Sep 25, 2021

Conversation

sestegra
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Replace ens33 by ens192 because the network adapter is vmxnet3.
  • Remove packages update from user-data because the update is managed by the script.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

Ubuntu 20.04 user-data

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@tenthirtyam tenthirtyam self-assigned this Sep 25, 2021
@tenthirtyam tenthirtyam added the type/bug Bug label Sep 25, 2021
@tenthirtyam tenthirtyam self-requested a review September 25, 2021 18:36
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🚀

  • Good catch for ens192. 👍
  • Good to remove the updates. 👍

Ryan

@tenthirtyam
Copy link
Collaborator

It seems that the change to ens192 is causing the failures seen in #56. Testing with a revert to ens33 resolves the issue.

tenthirtyam pushed a commit that referenced this pull request Sep 28, 2021
Reverting `ens192` to `ens33` from  PR #53 to address #56.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants