Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make content_library_destination optional #44

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Make content_library_destination optional #44

merged 1 commit into from
Sep 21, 2021

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Sep 21, 2021 •
edited by tenthirtyam
Loading

Summary of Pull Request

Add dynamic for content_library_destination block.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

Related to Existing Issues

Issue Number: #43

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
    - Verified by maintainer - @tenthirtyam
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@sestegra
Optional content_library_destination block
bb204a5 
Signed-off-by: Stéphane Este-Gracias <[email protected]>
@tenthirtyam tenthirtyam self-requested a review September 21, 2021 17:00
@tenthirtyam tenthirtyam changed the title [WIP] Optional content_library_destination block Optional content_library_destination block Sep 21, 2021
@tenthirtyam tenthirtyam changed the title Optional content_library_destination block Make content_library_destination optional Sep 21, 2021
@tenthirtyam tenthirtyam linked an issue Sep 21, 2021 that may be closed by this pull request
[BUG] content_library block should be null when common_template_conversion is true #43
Closed
1 task
tenthirtyam
tenthirtyam approved these changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that these changes have no impact and will commit to main for inclusion in the next release.

Ryan

@tenthirtyam tenthirtyam self-assigned this Sep 21, 2021
@tenthirtyam tenthirtyam merged commit 63f6a07 into vmware-samples:main Sep 21, 2021
@tenthirtyam tenthirtyam removed the status/planned Planned label Sep 21, 2021
@tenthirtyam
Copy link
Collaborator

Thanks for your contribution, @sestegra. 🚀

Ryan

@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Sep 21, 2021
@tenthirtyam tenthirtyam mentioned this pull request Oct 3, 2021
Closed
1 task
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
type/bug Bug type/enhancement Enhancement type/refactor Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] content_library block should be null when common_template_conversion is true
2 participants
@sestegra @tenthirtyam