Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ssh_proxy_* variables for Linux images #40

Merged
merged 6 commits into from
Sep 25, 2021
Merged

Support ssh_proxy_* variables for Linux images #40

merged 6 commits into from
Sep 25, 2021

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Sep 21, 2021

Summary of Pull Request
Add support of ssh_proxy_* variables for Linux images.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a something else.
    Please describe:

Context of the Pull Request*
#39

Related to Existing Issues
Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@tenthirtyam tenthirtyam added the status/under-review Under Review label Sep 21, 2021
@tenthirtyam
Copy link
Collaborator

@sestegra Can you confirm the following in the PR: Tests have been completed (for bug fixes/features)?

@tenthirtyam tenthirtyam self-assigned this Sep 21, 2021
@tenthirtyam tenthirtyam linked an issue Sep 21, 2021 that may be closed by this pull request
1 task
@sestegra
Copy link
Contributor Author

As discussed in thread #39, I can't test the proxy configuration with current local HTTP server.
I did some tests with my locally updated Ubuntu 20.04 user-data (using CD instead of HTTP server).

@tenthirtyam
Copy link
Collaborator

Thanks for the update. I'll hold this one and see if I can test it soon. I'm working on some other changes first in my spare time.

Ryan

Ryan Johnson and others added 2 commits September 22, 2021 19:09
@tenthirtyam tenthirtyam self-requested a review September 25, 2021 18:24
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run a 'packer fmt' against the updated 'linux-*.pkr.hcl' files to align formatting of the variables.

Ryan

Re-ordered the structure of the variables content.
@tenthirtyam tenthirtyam merged commit 6189c92 into vmware-samples:main Sep 25, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Support for a Packer host behind a proxy.
2 participants