Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use dedicated ansible modules #394

Merged
merged 4 commits into from
Nov 12, 2023
Merged

refactor: use dedicated ansible modules #394

merged 4 commits into from
Nov 12, 2023

Conversation

dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Dec 1, 2022

Summary of Pull Request

The existing Ansible playbooks / roles should use dedicated modules instead of shell commands.

For example the Ansible module ansible.posix.authorized_key automatically creates the .ssh directory and handles the permissions of the authorized_keys properly.

I also think that this project will benefit from the error messages that an Ansible module provides.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@dhoppe dhoppe requested a review from a team as a code owner December 1, 2022 10:27
@tenthirtyam tenthirtyam marked this pull request as draft December 1, 2022 12:00
@tenthirtyam tenthirtyam added the type/refactor Refactor label Dec 6, 2022
@tenthirtyam
Copy link
Collaborator

Hi @dhoppe - just check in to see if this is still a work in progress and if it should remain as a draft or ready for review.

Thanks!
Ryan

@tenthirtyam tenthirtyam added this to the .Next milestone Dec 13, 2022
@tenthirtyam tenthirtyam added the area/ansible Area: Ansible label Dec 13, 2022
@dhoppe
Copy link
Contributor Author

dhoppe commented Dec 13, 2022

@tenthirtyam I am still working on that. Yesterday I did some changes related to /clean and I need to cover VMware Photon as well.

@tenthirtyam
Copy link
Collaborator

@tenthirtyam I am still working on that. Yesterday I did some changes related to /clean and I need to cover VMware Photon as well.

Thanks for the update and the contributions, @dhoppe - it’s much appreciated. 🚀

@tenthirtyam
Copy link
Collaborator

Hi @dhoppe - let me know if you might have time to finish this pull request in the next couple of week - hoping to get a release out for end of January `23.

@dhoppe
Copy link
Contributor Author

dhoppe commented Jan 10, 2023

@tenthirtyam I am really sorry about this, but I am pretty busy right now. Feel free to solve the merge conflict and merge the pull request as it is. Everything else can be switched to Ansible later.

@tenthirtyam tenthirtyam modified the milestones: v23.01, .Next Jan 12, 2023
@tenthirtyam tenthirtyam added the status/planned Planned label Feb 11, 2023
@bschonec bschonec mentioned this pull request Apr 21, 2023
Closed
1 task
@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Jun 14, 2023 •
edited
Loading

I've rebased this pull request and will be looking into onboarding these great changes soon - thank you for your patience and contribution!

Will review opportunities for VMware Photon OS as well.

@tenthirtyam tenthirtyam self-requested a review June 14, 2023 22:00
@tenthirtyam tenthirtyam changed the title [WIP] refactor: Use dedicated Ansible modules instead of shell commands [WIP] refactor: use dedicated ansible modules Jun 14, 2023
@tenthirtyam tenthirtyam changed the title [WIP] refactor: use dedicated ansible modules refactor: use dedicated ansible modules Jun 15, 2023
@tenthirtyam tenthirtyam self-assigned this Jun 15, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review September 29, 2023 00:00
@tenthirtyam tenthirtyam force-pushed the refactor_ansible branch 3 times, most recently from fac2857 to 4194f10 Compare October 18, 2023 00:09
@tenthirtyam
Copy link
Collaborator

Rebased and updated with the newer distributions that have been updated.

This is next in the queue at long last.

cc @rcroft-work

@tenthirtyam tenthirtyam force-pushed the refactor_ansible branch 2 times, most recently from 7f5b95c to 8f9ddce Compare October 20, 2023 02:24
@tenthirtyam tenthirtyam modified the milestones: v23.10, .Next Oct 23, 2023
dhoppe and others added 3 commits November 12, 2023 09:36
@dhoppe @tenthirtyam
refactor: Use dedicated Ansible modules to manage local users
c346865
@dhoppe @tenthirtyam
refactor: Use dedicated Ansible modules to clean up the VM
91abd66
@tenthirtyam
feat: add new linux distros
eeddcd0 
Updates Linux distributions added recently:
- Debian 11
- Debian 12
- Oracle Linux 8
- Oracle Linux 9
- Photon 5

Signed-off-by: Ryan Johnson <[email protected]>
refactor: update ansible roles
2b5611f 
Refactors and reorganizes the Ansible roles to use dedicated modules and provide simplification.

Ref: vmware-samples#394

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
tenthirtyam approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased and completed the changes.

@tenthirtyam tenthirtyam merged commit 9b2dce9 into vmware-samples:develop Nov 12, 2023
tenthirtyam pushed a commit that referenced this pull request Nov 15, 2023
fix: ansible truncate machine-id
93c8e14 
Fixes the `machine-id` truncate issue introduced in #394.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam mentioned this pull request Nov 15, 2023
Merged
10 tasks
tenthirtyam pushed a commit that referenced this pull request Nov 15, 2023
fix: ansible truncate machine-id (#774)
70d4ecf 
Fixes the `machine-id` truncate issue introduced in #394.

Signed-off-by: Ryan Johnson <[email protected]>
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@dhoppe dhoppe

@tenthirtyam tenthirtyam

Labels
area/ansible Area: Ansible status/planned Planned type/refactor Refactor
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dhoppe @tenthirtyam