Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manage Headers instances in the JS kit #235

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: manage Headers instances in the JS kit #235

merged 1 commit into from
Oct 16, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Properly manage Headers instances by reusing them when a Response receives it. Before, a Headers object was causing a { headers: { headers: {} } object, which was wrong. I also took the opportunity to improve the Headers parsing by only allowing valid types (Object or Headers), and valid header values (string).

It fixes #233

@Angelmmiguel Angelmmiguel added 🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs labels Oct 16, 2023
@Angelmmiguel Angelmmiguel added this to the 1.7.0 milestone Oct 16, 2023
@Angelmmiguel Angelmmiguel requested a review from a team October 16, 2023 09:19
@Angelmmiguel Angelmmiguel self-assigned this Oct 16, 2023
ereslibre
ereslibre approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix :)

@Angelmmiguel Angelmmiguel merged commit 983540f into main Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre approved these changes

Assignees

@Angelmmiguel Angelmmiguel

Labels
🐛 bug Something isn't working cla-not-required 🔨 sdks Issues related to language SDKs
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Error when initializing Headers in the JavaScript kit
3 participants
@Angelmmiguel @ereslibre @vmwclabot