Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WASI-NN bindings to Wasm Workers Server #201

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

Angelmmiguel
Copy link
Contributor

@Angelmmiguel Angelmmiguel commented Aug 21, 2023

Introduce the new WASI-NN bindings to run Machine Learning (ML) inference in workers. It includes a new configuration parameter (features.wasi_nn) that allows you to set the allowed ML backends for a certain worker. Currently, it only supports openvino (OpenVINO) as a valid value.

In this PR you have a full working example you can test:

Screenshot 2023-08-21 at 13 41 33

Changes

  • Add new WASI-NN bindings
  • Enable them via configuration
  • Write documentation

It closes #198

@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label Aug 21, 2023
@Angelmmiguel Angelmmiguel added this to the v1.5.0 milestone Aug 21, 2023
@Angelmmiguel Angelmmiguel self-assigned this Aug 21, 2023
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite I'm not very familiar with all the concepts here, LGTM

crates/worker/src/lib.rs Outdated Show resolved Hide resolved
crates/worker/src/lib.rs Outdated Show resolved Hide resolved
crates/worker/src/lib.rs Outdated Show resolved Hide resolved
crates/worker/src/lib.rs Outdated Show resolved Hide resolved
crates/worker/src/lib.rs Outdated Show resolved Hide resolved
examples/rust-wasi-nn/src/main.rs Outdated Show resolved Hide resolved
examples/rust-wasi-nn/src/main.rs Show resolved Hide resolved
docs/docs/features/machine-learning.md Outdated Show resolved Hide resolved
docs/docs/features/machine-learning.md Outdated Show resolved Hide resolved
docs/docs/features/machine-learning.md Outdated Show resolved Hide resolved
docs/docs/features/machine-learning.md Outdated Show resolved Hide resolved
@Angelmmiguel Angelmmiguel marked this pull request as ready for review August 23, 2023 14:34
@Angelmmiguel Angelmmiguel merged commit 854a621 into main Aug 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce WASI-NN for Machine Learning inference
3 participants