Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): app level links to use specification colors #1632

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Links in app level alerts have default link colors.

Issue Number: CDE-2467

What is the new behavior?

Links in app level alerts follow the alert color specification.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team December 2, 2024 11:38
@valentin-mladenov valentin-mladenov self-assigned this Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov marked this pull request as ready for review December 2, 2024 11:38
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR introduces visual changes: 483cb6c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout app-level-alert-links-color-fix_cde-467
git fetch https://github.com/vmware-clarity/ng-clarity.git 483cb6c24d8f8a0c52cae9450009abc714befa2c
git cherry-pick 483cb6c24d8f8a0c52cae9450009abc714befa2c
git push

@valentin-mladenov valentin-mladenov changed the title fix(alerts): app level links have default colors fix(alerts): app level links to use specificstion colors Dec 2, 2024
@valentin-mladenov valentin-mladenov changed the title fix(alerts): app level links to use specificstion colors fix(alerts): app level links to use specification colors Dec 2, 2024
@valentin-mladenov valentin-mladenov merged commit 6107962 into main Dec 2, 2024
10 checks passed
@valentin-mladenov valentin-mladenov deleted the app-level-alert-links-color-fix_cde-467 branch December 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants