fix(a11y): signpost close aria label update and allow user to config aria label #1624
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
reviewed
Dec 3, 2024
| @@ -56,6 +56,8 @@ const POSITIONS: string[] = [ | |||
| host: { '[class.signpost-content]': 'true', '[id]': 'signpostContentId' }, | |||
| }) | |||
| export class ClrSignpostContent extends AbstractPopover implements OnDestroy { | |||
| @Input('clrSignpostCloseAriaLabel') signpostCloseAriaLabel: string; | |||
There was a problem hiding this comment.
Can we just use it as a default value?
Suggested change
| @Input('clrSignpostCloseAriaLabel') signpostCloseAriaLabel: string; | |
| @Input('clrSignpostCloseAriaLabel') signpostCloseAriaLabel = this.commonStrings.keys.signpostClose; |
There was a problem hiding this comment.
See my other comment for why defaulting to the common string in the template is better (and consistent with existing code). #1624 (comment)
dtsanevmw
reviewed
Dec 3, 2024
| @@ -40,7 +40,7 @@ const POSITIONS: string[] = [ | |||
| <div class="signpost-content-header"> | |||
| <button | |||
| type="button" | |||
| [attr.aria-label]="commonStrings.keys.signpostClose" | |||
| [attr.aria-label]="signpostCloseAriaLabel || commonStrings.keys.signpostClose" | |||
There was a problem hiding this comment.
Suggested change
| [attr.aria-label]="signpostCloseAriaLabel || commonStrings.keys.signpostClose" | |
| [attr.aria-label]="signpostCloseAriaLabel" |
There was a problem hiding this comment.
The current implementation is better so that we default to the common string if a falsy value is bound to the input. This is a pattern we use in several places, and I think this one should be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2461
What is the new behavior?
Does this PR introduce a breaking change?
Other information