-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion): add heading role and aria level to title #1616
base: main
Are you sure you want to change the base?
Conversation
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the implementation of stack-view where we are checking if the component is nested so we put 4 instead of 3 for the default value
This is a breaking change because it can cause pages with legal heading structure to suddenly have illegal heading structure due to the new headings. This can be fixed by not setting accordion titles as heading by default to maintain current heading structures. This should be an opt-in feature until v19. I have added the breaking change label due to the current implementation. If this issue is fixed, that can be removed. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Accordion and Stepper headers don't have
role
andaria-level
assigned.Issue Number: CDE-2437
What is the new behavior?
Accordion and Stepper headers have
role=heading
andaria-level
can be assigned from the user wit hdefaul value of 3.Does this PR introduce a breaking change?
Other information