Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagrid): add ability to unsort columns #1612

Merged
merged 14 commits into from
Nov 14, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Once turned on column sort can only be rotated between ASC and DESC when clicking on the column, but can't be turned off.

Issue Number: CDE-2416

What is the new behavior?

Column sort can be turned off by clicking third time on the column.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann changed the title feta(datagrid): triple sort column feat(datagrid): triple sort column Nov 6, 2024
@valentin-mladenov valentin-mladenov requested a review from a team November 7, 2024 12:22
@valentin-mladenov valentin-mladenov marked this pull request as ready for review November 7, 2024 12:24
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann
Copy link
Member

I would reword the PR title and commit message subject to "add ability to unsort columns".

@valentin-mladenov valentin-mladenov changed the title feat(datagrid): triple sort column feat(datagrid): add ability to unsort columns Nov 11, 2024
@valentin-mladenov
Copy link
Contributor Author

valentin-mladenov commented Nov 11, 2024

@kevinbuhmann clrDgSortDisableUnsort input is added in order to turn on/off the unsorted state of a column.
Does the name make sense?

@dtsanevmw can you review the changes we disscussed separately?

@kevinbuhmann
Copy link
Member

Has this gone through design? I'd like to see the proposed documentation/guidance before we release this. I'm not clear on why we need the ability to disable unsort. That might cause unnecessary UX differences in products. As a user I would not expect not to be able to unsort some grids/columns, but not all of them.

Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

@valentin-mladenov valentin-mladenov merged commit afcdafa into main Nov 14, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the datagrid-tripple-sort-columns_cde-2416 branch November 14, 2024 09:29
valentin-mladenov added a commit that referenced this pull request Nov 18, 2024
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants