Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): virtual scroll empty space after last row #1580

Merged

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When using virtual scroller empty space is available after the last row.

Issue Number: CDE-2313

What is the new behavior?

When using virtual scroller there is no empty space after the last row.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team October 3, 2024 08:30
@valentin-mladenov valentin-mladenov self-assigned this Oct 3, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 3, 2024 08:30
Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR introduces visual changes: 5a287d5
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-virtual-scroll-empty-space_cde-2313
git fetch https://github.com/vmware-clarity/ng-clarity.git 5a287d5701fdbf841692467892607037d089b331
git cherry-pick 5a287d5701fdbf841692467892607037d089b331
git push

Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the cdk-virtual-scrollable that is being set by CDK on the datagrid element
Screenshot 2024-10-03 at 15 41 06

@valentin-mladenov
Copy link
Contributor Author

valentin-mladenov commented Oct 3, 2024

You can use the cdk-virtual-scrollable that is being set by CDK on the datagrid element.

I searched for exactly that class, but didn't find it during in my initial fix.

@valentin-mladenov valentin-mladenov merged commit be2d3ff into main Oct 3, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the datagrid-virtual-scroll-empty-space_cde-2313 branch October 3, 2024 14:47
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants