fix(tree-view): add aria multiselectable attribute when needed #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
mivaylo
approved these changes
Sep 26, 2024
kevinbuhmann
approved these changes
Sep 30, 2024
valentin-mladenov
deleted the
tree-view-expression-changed-error_cde-2301
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? `clr-tree` throws ExpressionChangedAfterItHasBeenCheckedError when setting `aria-multiselectable`. Issue Number: #1562, CDE-2301 ## What is the new behavior? Aria multiselectable attribute is added when needed. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information (cherry picked from commit 71b0056)
13 tasks
valentin-mladenov
added a commit
that referenced
this pull request
Sep 30, 2024
…ort to 16.x) (#1572) Backport 71b0056 from #1563. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? `clr-tree` throws ExpressionChangedAfterItHasBeenCheckedError when setting `aria-multiselectable`. Issue Number: #1562, CDE-2301 ## What is the new behavior? Aria multiselectable attribute is added when needed. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information Co-authored-by: Valentin Mladenov <[email protected]>
|
🎉 This PR is included in version 17.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
clr-treethrows ExpressionChangedAfterItHasBeenCheckedError when settingaria-multiselectable.Issue Number: #1562, CDE-2301
What is the new behavior?
Aria multiselectable attribute is added when needed.
Does this PR introduce a breaking change?
Other information