fix(a11y): clr-password-container show/hide Icon does not have unique label #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
requested changes
Jan 31, 2024
kevinbuhmann
approved these changes
Feb 2, 2024
added 4 commits
February 5, 2024 12:59
… label - adds a unique label for each password show/hide icon specifically for screen readers. Close: #CDE-1179 Signed-off-by: Andrea Fernandes <[email protected]>
…ls for screen readers Signed-off-by: Andrea Fernandes <[email protected]>
Signed-off-by: Andrea Fernandes <[email protected]>
Signed-off-by: Andrea Fernandes <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
… label (#1179) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Signed-off-by: Andrea Fernandes <[email protected]> Co-authored-by: Andrea Fernandes <[email protected]> (cherry picked from commit cabb89d)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
… label (#1179) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Signed-off-by: Andrea Fernandes <[email protected]> Co-authored-by: Andrea Fernandes <[email protected]> (cherry picked from commit cabb89d)
andyfeds
added a commit
that referenced
this pull request
Feb 6, 2024
… label (backport to 15.x) (#1195) Backport cabb89d from #1179. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Andrea A Fernandes <[email protected]>
andyfeds
added a commit
that referenced
this pull request
Feb 6, 2024
… label (#1179) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Signed-off-by: Andrea Fernandes <[email protected]> Co-authored-by: Andrea Fernandes <[email protected]> (cherry picked from commit cabb89d)
andyfeds
added a commit
that referenced
this pull request
Feb 6, 2024
… label (backport to next) (#1196) Backport cabb89d from #1179. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Andrea A Fernandes <[email protected]>
dtsanevmw
pushed a commit
that referenced
this pull request
Feb 8, 2024
… label (#1179) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1179 ## What is the new behavior? Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Signed-off-by: Andrea Fernandes <[email protected]> Co-authored-by: Andrea Fernandes <[email protected]>
|
🎉 This PR is included in version 16.3.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 16.3.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Clarity uses constants/static text to label the show/ hide icon corresponding to the password input field, this is not unique for each clr-password-container input. It currently only ever reads as Show password / Hide password when using a screen reader.
Issue Number: CDE-1179
What is the new behavior?
Each individual show/hide icon button corresponding to a password field will now announce the unique label name (associated to that field) in addition to Show password / Hide password when using a screen reader.
Does this PR introduce a breaking change?
Other information