Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): ignore non-string values in date service parser (backport to next) #1171

Merged
merged 1 commit into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. fix(date-picker): ignore non-string values in date service parser (#1169

    )
    
    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    If Date object is passed to the control and that's being passed to
    'getDateValueFromDateString' which accepts strings only -- the control
    breaks and freezes.
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: #975 CDE-1578
    
    ## What is the new behavior?
    
    Ignore non-string values which are passed to that function.
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    Co-authored-by: Venkatesh Rajendran <[email protected]>
    (cherry picked from commit 64f10c4)
    venkateshr06 authored and github-actions[bot] committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7fa7e83 View commit details
    Browse the repository at this point in the history