Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): resolve clickable card hover shifting text (#1166) #1170

Merged

Commits on Jan 26, 2024

  1. fix(card): resolve clickable card hover shifting text (#1166)

    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [X] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    When hovering over clickable card the border width animates from 1px to
    2px, causing the text content contained within the card to noticeably
    shift. This can be seen when hovering the clickable card on our
    [website](https://clarity.design/documentation/card/code#clickable-cards)
    and our
    [storybook](https://storybook.clarity.design/?path=/story/card-card--default).
    
    Issue Number: CDE-917
    
    This changes the clickable border-width token to 1px (which is the
    correct value for non-hovered clickable cards), and then uses the
    box-shadow to set a 1px shadow around the element. Since both the
    box-shadow and the border-color are the same color, and they're both 1px
    by default, the result is a non-shifting 2px stroke on hover.
    
    - [ ] Yes
    - [X] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    williamernest committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a66d498 View commit details
    Browse the repository at this point in the history