fix(button group): fix border disappears in button group with disable (port of 1139) #1148
Commits on Jan 22, 2024
-
fix(button group): fix border disappears in button group with disable (…
…#1139) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #915, CDE-1563 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Srinivas Padidapelli <[email protected]> Co-authored-by: GitHub <[email protected]> Co-authored-by: Kevin Buhmann <[email protected]> # Conflicts: # tests/snapshots/button/button-group--variants-core-dark.png # tests/snapshots/button/button-group--variants-core-light.png # tests/snapshots/button/button-group--variants-ng-dark.png # tests/snapshots/button/button-group--variants-ng-light.png
-
fix(button group): fix border disappears in button group with disable (…
…#1139) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #915, CDE-1563 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Srinivas Padidapelli <[email protected]> Co-authored-by: GitHub <[email protected]> Co-authored-by: Kevin Buhmann <[email protected]> # Conflicts: # tests/snapshots/button/button-group--variants-core-dark.png # tests/snapshots/button/button-group--variants-core-light.png # tests/snapshots/button/button-group--variants-ng-dark.png # tests/snapshots/button/button-group--variants-ng-light.png
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.