fix(button-group): handle keyboard focus for async menu buttons #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
force-pushed
the
kevin/button-group-async-menu
branch
from
a5b6132
to
4507b45
Compare
kevinbuhmann
added a commit
that referenced
this pull request
Jan 19, 2024
With both synchronous and asynchronous population, focus is moved to the first menu button when the button group menu is opened, keyboard focus works properly, and the menu is closed when one of the menu buttons is activated. CDE-1571 closes #952
This was referenced Jan 19, 2024
|
🎉 This PR is included in version 16.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Bugfix
What is the current behavior?
If button group menu buttons are populated asynchronously, focus is not handled properly and the menu is not closed when one of the menu buttons is activated.
Issue Number: #952, CDE-1571
What is the new behavior?
With both synchronous and asynchronous population, focus is moved to the first menu button when the button group menu is opened, keyboard focus works properly, and the menu is closed when one of the menu buttons is activated.
Does this PR introduce a breaking change?
No