Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): prevent error with nested accordions #1121

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

kevinbuhmann
Copy link
Member

This is a port of 898e1df (#1119) to 17.x.

An instance of the accordion component should only care about its own panels. Including nested accordions' panels causes an error when trying to update panels that don't belong the parent instance.

closes #1118

This is a port of 898e1df (#1119)
to 17.x.

An instance of the accordion component should only care about its own
panels. Including nested accordions' panels causes an error when trying
to update panels that don't belong the parent instance.

closes #1118
Copy link
Contributor

github-actions bot commented Jan 8, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann merged commit d254c48 into next Jan 8, 2024
6 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/nested-accordion-error-next branch January 8, 2024 19:34
Copy link
Contributor

🎉 This PR is included in version 17.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants