-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datagrid): add ability to unsort columns #1612
feat(datagrid): add ability to unsort columns #1612
Conversation
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would reword the PR title and commit message subject to "add ability to unsort columns". |
@kevinbuhmann @dtsanevmw can you review the changes we disscussed separately? |
Has this gone through design? I'd like to see the proposed documentation/guidance before we release this. I'm not clear on why we need the ability to disable unsort. That might cause unnecessary UX differences in products. As a user I would not expect not to be able to unsort some grids/columns, but not all of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments.
All changes are resolved.
8ec5349
to
0cdbe45
Compare
This reverts commit afcdafa.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Once turned on column sort can only be rotated between
ASC
andDESC
when clicking on the column, but can't be turned off.Issue Number: CDE-2416
What is the new behavior?
Column sort can be turned off by clicking third time on the column.
Does this PR introduce a breaking change?
Other information