fix(card): resolve clickable card hover shifting text (#1166) #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: When hovering over clickable card the border width animates from 1px to 2px, causing the text content contained within the card to noticeably shift. This can be seen when hovering the clickable card on our [website](https://clarity.design/documentation/card/code#clickable-cards) and our [storybook](https://storybook.clarity.design/?path=/story/card-card--default). Issue Number: CDE-917 This changes the clickable border-width token to 1px (which is the correct value for non-hovered clickable cards), and then uses the box-shadow to set a 1px shadow around the element. Since both the box-shadow and the border-color are the same color, and they're both 1px by default, the result is a non-shifting 2px stroke on hover. - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
approved these changes
Jan 26, 2024
williamernest
deleted the
wernest/fix_clickable_card_hover_text_shift_port_cde-917
branch
|
🎉 This PR is included in version 17.0.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 17.0.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 17.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #1166
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
When hovering over clickable card the border width animates from 1px to 2px, causing the text content contained within the card to noticeably shift. This can be seen when hovering the clickable card on our website and our
storybook.
Issue Number: CDE-917
This changes the clickable border-width token to 1px (which is the correct value for non-hovered clickable cards), and then uses the box-shadow to set a 1px shadow around the element. Since both the box-shadow and the border-color are the same color, and they're both 1px by default, the result is a non-shifting 2px stroke on hover.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information