fix(button group): fix border disappears in button group with disable (port of 1139) #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1139) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #915, CDE-1563 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Srinivas Padidapelli <[email protected]> Co-authored-by: GitHub <[email protected]> Co-authored-by: Kevin Buhmann <[email protected]> # Conflicts: # tests/snapshots/button/button-group--variants-core-dark.png # tests/snapshots/button/button-group--variants-core-light.png # tests/snapshots/button/button-group--variants-ng-dark.png # tests/snapshots/button/button-group--variants-ng-light.png
…#1139) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #915, CDE-1563 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Srinivas Padidapelli <[email protected]> Co-authored-by: GitHub <[email protected]> Co-authored-by: Kevin Buhmann <[email protected]> # Conflicts: # tests/snapshots/button/button-group--variants-core-dark.png # tests/snapshots/button/button-group--variants-core-light.png # tests/snapshots/button/button-group--variants-ng-dark.png # tests/snapshots/button/button-group--variants-ng-light.png
Thank you, 🤖 Clarity Release Bot |
spadidapelli
changed the title
|
This PR introduces visual changes: 76b8b06 |
valentin-mladenov
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM
@spadidapelli please update the PR Checklist's Issue Number with GH issue number and JIRA tikcet ID, also tick all relevant checkboxes.
Assign yourself as assignee on the PR
Add the following PR labels type:fix and v15.
Add at the end of PR's title (port of 1139) with the hashtag.
spadidapelli
changed the title
spadidapelli
changed the title
|
🎉 This PR is included in version 17.0.0-beta.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #915 CDE-1563
What is the new behavior?
Does this PR introduce a breaking change?
Other information