Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): update positioning logic to render within body #1109

Merged
merged 4 commits into from
Feb 2, 2024
Merged

fix(popover): update positioning logic to render within body #1109

merged 4 commits into from
Feb 2, 2024

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented Dec 15, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

datepicker popover position example

Issue Number: CDE-1508

What is the new behavior?

datepicker positioning logic after example

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

👋 @williamernest,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@williamernest williamernest force-pushed the wernest/fix_popover_logic_render_in_body_cde-1508 branch from 21491c8 to 6d79972 Compare January 29, 2024 22:40
@williamernest williamernest marked this pull request as ready for review January 31, 2024 01:29
@williamernest williamernest changed the base branch from 15.x to main January 31, 2024 22:16
@williamernest williamernest force-pushed the wernest/fix_popover_logic_render_in_body_cde-1508 branch from 7141fac to bcf8a5f Compare January 31, 2024 22:19
@williamernest williamernest requested a review from a team February 2, 2024 01:53
Jinnie
Jinnie approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM until we land the bigger refactor

@williamernest williamernest merged commit 3a04da1 into main Feb 2, 2024
4 checks passed
@williamernest williamernest deleted the wernest/fix_popover_logic_render_in_body_cde-1508 branch February 2, 2024 16:54
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@williamernest @github-actions
fix(popover): update positioning logic to render within body (#1109)
27c7ba2 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

![datepicker popover position
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/0d078063-c542-472c-a892-d5864eb61756)

Issue Number: CDE-1508

## What is the new behavior?

![datepicker positioning logic after
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/61eecd6f-d708-468f-b6c9-8ab5c40c5db9)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit 3a04da1)
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
13 tasks
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@williamernest @github-actions
fix(popover): update positioning logic to render within body (#1109)
a0403d2 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

![datepicker popover position
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/0d078063-c542-472c-a892-d5864eb61756)

Issue Number: CDE-1508

## What is the new behavior?

![datepicker positioning logic after
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/61eecd6f-d708-468f-b6c9-8ab5c40c5db9)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit 3a04da1)
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
13 tasks
williamernest added a commit that referenced this pull request Feb 2, 2024
@github-actions @williamernest
fix(popover): update positioning logic to render within body (backpor…
f6cba54 
…t to next) (#1192)

Backport 3a04da1 from #1109. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [X] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

![datepicker popover position
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/0d078063-c542-472c-a892-d5864eb61756)

Issue Number: CDE-1508

## What is the new behavior?

![datepicker positioning logic after
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/61eecd6f-d708-468f-b6c9-8ab5c40c5db9)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Will Ernest <[email protected]>
williamernest added a commit that referenced this pull request Feb 2, 2024
@github-actions @williamernest
fix(popover): update positioning logic to render within body (backpor…
a781149 
…t to 15.x) (#1193)

Backport 3a04da1 from #1109. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [X] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

![datepicker popover position
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/0d078063-c542-472c-a892-d5864eb61756)

Issue Number: CDE-1508

## What is the new behavior?

![datepicker positioning logic after
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/61eecd6f-d708-468f-b6c9-8ab5c40c5db9)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Will Ernest <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 16.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

dtsanevmw pushed a commit that referenced this pull request Feb 8, 2024
@williamernest @dtsanevmw
fix(popover): update positioning logic to render within body (#1109)
726210f 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

![datepicker popover position
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/0d078063-c542-472c-a892-d5864eb61756)

Issue Number: CDE-1508

## What is the new behavior?

![datepicker positioning logic after
example](https://github.com/vmware-clarity/ng-clarity/assets/34519388/61eecd6f-d708-468f-b6c9-8ab5c40c5db9)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jinnie Jinnie Jinnie approved these changes

Assignees

@williamernest williamernest

Labels
auto-backport-to-15.x cla-not-required released type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamernest @Jinnie @vmwclabot