Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fixes a problem due to a breaking TS change #187

Merged

Conversation

ryan-bradford
Copy link
Contributor

Description

Fixes a problem where a getter was not being compiled to a readonly in the .d.ts files. This causes the error that error TS1086: An accessor cannot be declared in an ambient context.. This is because of a TS breaking change microsoft/TypeScript#33939.

Testing

Inspected the TS output and made sure it did not contain any getters.

Signed-off-by: Ryan Bradford [email protected]

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          83       83           
  Lines        2894     2894           
  Branches      457      457           
=======================================
  Hits         2616     2616           
  Misses        183      183           
  Partials       95       95           
Impacted Files Coverage Δ
...s/i18n/src/lib/service/mock-translation-service.ts 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30dc90c...20c976d. Read the comment docs.

@ryan-bradford ryan-bradford merged commit ee1662f into vmware-archive:master Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants