This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Resolve Issue 566 #567
Closed
Resolve Issue 566 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue that prevents the Remove-NSXSecurityGroupMember cmdlet from being able to remove excludeMember objects from the Security Group.
Fix indents to use spaces instead of tabs on the remove-nsxsecuritygroupmember excludeMember fix.
|
@NamedJason, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@NamedJason, VMware has approved your signed contributor license agreement. |
|
Hi @NamedJason There is a issue when you change it is very big (you don't have change all indent ?) |
|
Ok. I used tabs for indents on my new lines, but then I saw that the rest of the file uses spaces, so that second edit was just me changing my new lines to use spaces, too.
…________________________________
From: Alexis La Goutte <[email protected]>
Sent: Monday, February 18, 2019 7:05 AM
To: vmware/powernsx
Cc: NamedJason; Mention
Subject: Re: [vmware/powernsx] Resolve Issue 566 (#567)
Hi @NamedJason<https://github.com/NamedJason>
There is a issue when you change it is very big (you don't have change all indent ?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#567 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AObTCVARu81dVhOpXCH7KhV8huyqR7Dkks5vOsFTgaJpZM4ac9uP>.
|
|
What editor do you have using ? |
|
NPP - I usually use tabs, so I just did so here in my initial version. When I uploaded it to github, it looked funky and that's when I realized that the rest of the file uses spaces instead, so I changed to try and follow the existing style.
…________________________________
From: Alexis La Goutte <[email protected]>
Sent: Monday, February 18, 2019 9:49 AM
To: vmware/powernsx
Cc: NamedJason; Mention
Subject: Re: [vmware/powernsx] Resolve Issue 566 (#567)
What editor do you have using ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#567 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AObTCQOIbbnx0Mr1oEMXvRMgo_WcBUl5ks5vOufEgaJpZM4ac9uP>.
|
|
fixed by #647 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a line to allow remove-nsxSecurityGroupMember to properly detect excludeMember objects so that it can remove them.
I'm sorry if I'm doing this wrong, I'm a beginner with Git. Please let me know if I need to do something differently.