This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Added status column to Pod list #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftovaro
force-pushed
the
issue-201
branch
4 times, most recently
from
5e3e3b7
to
56d7ffd
Compare
ftovaro
changed the title
ftovaro
force-pushed
the
issue-201
branch
2 times, most recently
from
999d1a3
to
a2057e8
Compare
Signed-off-by: ftovaro <[email protected]>
| @@ -70,6 +70,22 @@ func PodListHandler(ctx context.Context, list *corev1.PodList, opts Options) (co | |||
|
|
|||
| row["Phase"] = component.NewText(string(pod.Status.Phase)) | |||
|
|
|||
| if len(pod.Status.ContainerStatuses) > 0 { | |||
| lastStatus := pod.Status.ContainerStatuses[len(pod.Status.ContainerStatuses)-1] | |||
There was a problem hiding this comment.
Nitpicking here but the logic to determine the status can go inside a private method.
There was a problem hiding this comment.
Could be but don't you think that the logic is too simple for that and also a method would have at least 3 lines of code and here we can have it with just one
xtreme-vikram-yadav
approved these changes
Jul 26, 2021
wwitzel3
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ftovaro [email protected]
What this PR does / why we need it:
Adds a new column called Status that reflects the status of a Pod in addition to the Phase that is already on the table.
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: