This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Make Resource Viewer layout repeatable #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Klanjsek <[email protected]>
|
It looks great to me!! |
|
👍 |
GuessWhoSamFoo
approved these changes
Apr 25, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change divides the Resource Viewer node discovery in two parts: first during the tree traversal nodes are added to a cache, and at the end of traversal cached nodes are sorted and applied to the Resource Viewer layout. That ensures repeatable node order and consequently graph layout, while keeping the performance similar as before. This approach turned out to be more reliable than my first attempt of synchronizing the node creation by using go channels.
Nodes are sorted first by tree depth level and then by node kind/name. This not only improves the visual layout, but it also groups nodes of same kind closer together, opening a door for node grouping and collapsing/expanding.
Signed-off-by: Milan Klanjsek [email protected]