This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Adds dropdowns to breadcrumbs #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklanjsek
force-pushed
the
breadcrumbs-with-dropdowns
branch
3 times, most recently
from
6992ade
to
9c27ec9
Compare
|
Just jumped off a call with @mklanjsek , most of the review comments here are likely going to be irrelevant with suggested refactors. |
mklanjsek
force-pushed
the
breadcrumbs-with-dropdowns
branch
from
0385dae
to
6b1870a
Compare
GuessWhoSamFoo
suggested changes
Jan 5, 2021
Signed-off-by: Milan Klanjsek <[email protected]> Added changelog file Signed-off-by: Milan Klanjsek <[email protected]> Added dropdown overflow logic Signed-off-by: Milan Klanjsek <[email protected]> Illustrate using breadcrumbs from plugins, fix for component unmarshal issue Added dropdown to list of docs generating components, get rid of console warning Signed-off-by: Milan Klanjsek <[email protected]> Switch to use module navigation data Signed-off-by: Milan Klanjsek <[email protected]> Removed old breadcrumbs code and RootPath logic Signed-off-by: Milan Klanjsek <[email protected]> Code review feedback Signed-off-by: Milan Klanjsek <[email protected]>
mklanjsek
force-pushed
the
breadcrumbs-with-dropdowns
branch
from
1a8dcd6
to
056611e
Compare
|
@GuessWhoSamFoo PTAL, I made changes or commented on your points and squashed all commits. Thanks for reviewing it so quickly! |
GuessWhoSamFoo
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where applicable, breadcrumbs will now contain dropdown controls, providing additional way to navigate directly from the breadcrumb bar.
Most notable changes:
Selectionproperty to dropdown that can be used to specify selected item,Signed-off-by: Milan Klanjsek [email protected]
Which issue(s) this PR fixes