Merge pull request #2046 from lenriquez/issue-1462

Removed resource age column since the information is repeated

changelogs/unreleased/1462-lenriquez

@@ -0,0 +1 @@
+Removed resource age column from Custom Resources

internal/printer/customresource.go

@@ -71,8 +71,14 @@ func (crl *CustomResourceLister) List(crdObject *unstructured.Unstructured, reso
 		}
 
 		for _, column := range v.PrinterColumns {
+			// Base on this issue https://github.com/vmware-tanzu/octant/issues/1462
+			// Resource Age is not necessary since it has the same info as Age
+			if column.Name == "Age" {
+				continue
+			}
+
 			name := column.Name
-			if octantStrings.Contains(column.Name, []string{"Name", "Labels", "Age"}) {
+			if octantStrings.Contains(column.Name, []string{"Name", "Labels"}) {
 				name = fmt.Sprintf("Resource %s", column.Name)
 			}
 			table.AddColumn(name)
@@ -104,6 +110,10 @@ func (crl *CustomResourceLister) List(crdObject *unstructured.Unstructured, reso
 		row["Age"] = component.NewTimestamp(cr.GetCreationTimestamp().Time)
 
 		for _, column := range version.PrinterColumns {
+			if column.Name == "Age" {
+				continue
+			}
+
 			s, err := printCustomColumn(cr.Object, column)
 			if err != nil {
 				return nil, fmt.Errorf("print custom column %q in CRD %q: %w",

internal/printer/customresource_test.go

@@ -89,16 +89,16 @@ func TestCustomResourceLister_List(t *testing.T) {
 			wantErr: false,
 			want: component.NewTableWithRows(
 				"crontabs.stable.example.com/v1", "We could not find any crontabs.stable.example.com/v1!",
-				component.NewTableCols("Name", "Labels", "Spec", "Replicas", "Errors", "Resource Age", "Age"),
+				component.NewTableCols("Name", "Labels", "Spec", "Replicas", "Errors", "Resource Name", "Age"),
 				[]component.TableRow{
 					{
-						"Name":         component.NewLink("", "my-crontab", "/my-crontab"),
-						"Age":          component.NewTimestamp(now),
-						"Labels":       component.NewLabels(labels),
-						"Replicas":     component.NewText("1"),
-						"Spec":         component.NewText("* * * * */5"),
-						"Errors":       component.NewText("1"),
-						"Resource Age": component.NewText(now.UTC().Format(time.RFC3339)),
+						"Name":          component.NewLink("", "my-crontab", "/my-crontab"),
+						"Age":           component.NewTimestamp(now),
+						"Labels":        component.NewLabels(labels),
+						"Replicas":      component.NewText("1"),
+						"Spec":          component.NewText("* * * * */5"),
+						"Errors":        component.NewText("1"),
+						"Resource Name": component.NewText("my-crontab"),
 					},
 				}),
 		},

internal/printer/testdata/crd-additional-columns.yaml

@@ -29,3 +29,7 @@ spec:
       type: string
       description: A custom timestamp
       JSONPath: .metadata.creationTimestamp
+    - name: Name
+      type: string
+      description: A custom name
+      JSONPath: .metadata.name