This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
GKE: Enable integration tests #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sameersbn
commented
Nov 5, 2018
•
sameersbn
commented
- Configure CI setup for testing on GKE clusters
- Configure DNS suffix for GKE tests
- Clean up disk leakage
- Debug monitoring test failures in GKE
sameersbn
force-pushed
the
anguslees-gketests
branch
2 times, most recently
from
57658b1 to
44b7461
Compare
sameersbn
added
ci
sameersbn
force-pushed
the
anguslees-gketests
branch
2 times, most recently
from
3344ff1 to
489c6ee
Compare
anguslees
suggested changes
Nov 9, 2018
Jenkinsfile
Outdated
| @@ -224,15 +242,15 @@ spec: | |||
| // $AZURE_SUBSCRIPTION_ID, $AZURE_TENANT_ID. | |||
| withCredentials([azureServicePrincipal('jenkins-bkpr-owner-sp')]) { | |||
| def resourceGroup = 'jenkins-bkpr-rg' | |||
| def clusterName = ("${env.BRANCH_NAME}".take(8) + "-${env.BUILD_NUMBER}-${platform}-" + UUID.randomUUID().toString().take(5)).replaceAll(/[^a-zA-Z0-9-]/, '-').toLowerCase() | |||
| def clusterName = ("${env.BRANCH_NAME}".take(8) + "-${env.BUILD_NUMBER}-" + UUID.randomUUID().toString().take(5) + "-${platform}").replaceAll(/[^a-zA-Z0-9-]/, '-').toLowerCase() | |||
There was a problem hiding this comment.
We need more uniqueness than platform+BUILD_NUMBER? This expression is getting a bit silly - I think if we're going to include a random component, then lets just drop all the non-random bits and rely on tags/labels to report meta-info.
There was a problem hiding this comment.
The truncation removes the uniqueness. This change essentially is to make sure the uniqueness does not get removed as a result of truncation. As a result I can reliably query leftover gce disks using a filter and remove them.
sameersbn
force-pushed
the
anguslees-gketests
branch
3 times, most recently
from
99af496 to
7de4193
Compare
sameersbn
changed the title
|
@anguslees please take a look. |
sameersbn
force-pushed
the
anguslees-gketests
branch
from
a430a75 to
2b64d72
Compare
sameersbn
force-pushed
the
anguslees-gketests
branch
from
2b64d72 to
3fbcb8f
Compare
Signed-off-by: Sameer Naik <[email protected]>
Signed-off-by: Sameer Naik <[email protected]>
when the cluster is delete synchronously the dns zone gets cleaned up and the subsequent call to delete the zone executes successfully.
added 7 commits
November 12, 2018 12:09
sameersbn
force-pushed
the
anguslees-gketests
branch
from
95e2237 to
cf5c023
Compare
sameersbn
referenced
this pull request
in sameersbn/kube-prod-runtime
Nov 12, 2018
* GKE: Enable integration tests Signed-off-by: Sameer Naik <[email protected]> * fix GKE integration test setup Signed-off-by: Sameer Naik <[email protected]> * let gke select the latest available k8s patch release * define `waitForRollout` utility function * drop `+k8s` string from platform name * insert the random string before the platform substring * wait for deployments in `kube-system` namespace to rollout * fix command to delete dns zone * remove `--async` flag from GKE cluster deletion when the cluster is delete synchronously the dns zone gets cleaned up and the subsequent call to delete the zone executes successfully. * fix gke disk leakage * break multiline command block * purge zone records before deleting the zone * cleanup `gcloud container clusters create` command * remove double dashes from clusterName * add utility functions to update glue records * setup glue records for gke tests * remove `--dns-suffix` requirement for monitoring tests * specify machine-type in gke cluster create command * let kubeprod create the dns zone * nameServers as a ArrayList to insertGlueRecords (cherry picked from commit bda226f) Signed-off-by: Sameer Naik <[email protected]>
sameersbn
added
backports/done
and removed
backports/queue
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.