Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Single server binary #557

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Conversation

kars7e
Copy link
Contributor

@kars7e kars7e commented Jul 9, 2018

Changes:

  • All services are now executed from single binary, dispatch-server. This allows easier management of middlewares, and also allows dispatch-server local to exist (added earlier).
  • All images (but event-sidecar) have been merged into single image "dispatch-server".
  • Configuration has been unified: no more pkg/config, There is a single place that reads config file, flags and environment variables.
  • Services now only listen on HTTP port 80, since TLS is terminated at Ingress (But enabling it back will be easy).
  • Charts have been adjusted, and most importantly, cleaned up from unused volumes (e.g. API manager had volume with Docker socket mounted).
  • Config files in charts are slimmed down and are using YAML instead of JSON for better readability.
  • Application manager chart has been removed for now. We don't use it, and it's been broken for some time now (e2e tests for application manager have been gone for couple releases).
  • Some services have been "deglobalized" - the global flags are gone, and those services that were using global variables have been converted to use struct-level variables that are configured during initialization.

Closes #518

@kars7e kars7e force-pushed the single-server-binary branch 3 times, most recently from 5a9da5c to 7fb3e6b Compare July 10, 2018 08:38
@kars7e kars7e changed the title [DNM] WIP:Single server binary Single server binary Jul 10, 2018
@kars7e kars7e force-pushed the single-server-binary branch 5 times, most recently from fa61ddf to aa0703d Compare July 10, 2018 21:47
Changes:
* All services are now executed from single binary, `dispatch-server`.
This allows easier management of middlewares, and also allows `dispatch-server local` to exist (added earlier).
* All images (but event-sidecar) have been merged into single image "dispatch-server".
* Configuration has been unified: no more `pkg/config`,
there is a single place that reads config file, flags and environment variables.
* Services now only listen on HTTP port 80, since TLS is terminated at Ingress
(But enabling it back will be easy).
* Charts have been adjusted, and most importantly, cleaned up from unused volumes
(e.g. API manager had volume with Docker socket mounted).
* Config files in charts are slimmed down and are using YAML instead of JSON for better readability.
* Application manager chart has been removed for now. We don't use it,
and it's been broken for some time now (e2e tests for application manager have been gone for couple releases).
* Some services have been "deglobalized" - the global flags are gone,
and those services that were using global variables have been converted to use
struct-level variables that are configured during initialization.
Copy link
Contributor

@neosab neosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants