Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Add version command #289

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Conversation

kars7e
Copy link
Contributor

@kars7e kars7e commented Mar 8, 2018

$ make cli-darwin
GOOS=darwin go build -ldflags " -X github.com/vmware/dispatch/pkg/version.version=v0.1.7 -X github.com/vmware/dispatch/pkg/version.buildDate=2018-03-08T02:23:12Z -X github.com/vmware/dispatch/pkg/version.commit=7a5a611a74190d7b84ef1da3767ce58d2ad693bd " -o bin/dispatch-darwin ./cmd/dispatch

$ bin/dispatch-darwin version
v0.1.7-7a5a611a74

Release pipeline would need some tunning to automatically bump versions

markpeek
markpeek previously approved these changes Mar 8, 2018
@markpeek markpeek merged commit 848c6eb into vmware-archive:master Mar 8, 2018
@kars7e kars7e mentioned this pull request Mar 8, 2018
3 tasks
Copy link
Contributor

@berndtj berndtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is late... I think we can enhance this to include client and server versioning and also get the version from the build rather than having to remember to bump the version in the makefile.

# To be bumped by every release
VERSION_MAJOR ?= 0
VERSION_MINOR ?= 1
VERSION_BUILD ?= 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to forget to do this. I'd like a future version of this change to pull the version from a file which effectively is written by the build system.

}

// Get returns information about the build
func Get() *BuildInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we get the server version?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants